From c733b9e25c705d9680531055d7136570cf90dd2e Mon Sep 17 00:00:00 2001 From: Paul Durrant Date: Fri, 21 Feb 2020 11:20:45 +0000 Subject: [PATCH] libxl: modify libxl__logv() to only log valid domid values Some code-paths use values other than INVALID_DOMID to indicate an invalid domain id. Specifically, xl will pass a value of 0 when creating/restoring a domain. Therefore modify libxl__logv() to use libxl_domid_valid_guest() as a validity test. Signed-off-by: Paul Durrant Acked-by: Ian Jackson Acked-by: Wei Liu --- tools/libxl/libxl_internal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_internal.c b/tools/libxl/libxl_internal.c index 211236dc99..a7da2921de 100644 --- a/tools/libxl/libxl_internal.c +++ b/tools/libxl/libxl_internal.c @@ -234,7 +234,7 @@ void libxl__logv(libxl_ctx *ctx, xentoollog_level msglevel, int errnoval, fileline[sizeof(fileline)-1] = 0; domain[0] = 0; - if (domid != INVALID_DOMID) + if (libxl_domid_valid_guest(domid)) snprintf(domain, sizeof(domain), "Domain %"PRIu32":", domid); x: xtl_log(ctx->lg, msglevel, errnoval, "libxl", -- 2.30.2